-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace game manuals 1 & 2 with the new Competition Manual #295
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We also need a pull request removing the field setup guide so the link check will pass. (this may wait until the ITD field setup guide is available)
@alan412 We also need to change all references to the "Game Manuals" page to be to the "Competition Manuals" page. I'm currently in the process of doing that. For the field setup guide, I'll probably just replace that link with a "coming soon" note since the check failing makes it annoying to merge PRs with content. |
We also need to add it to the redirects list in the config |
@uvidyadharan I'm not entirely sure what you mean. I can't seem to find any redirect list in conf.py. Was I looking in the wrong place? |
Could you make sure to rename the game manual page to competition manual? @miriamsr |
docs/source/control_hard_compon/rc_components/hub/ports/std-ports.rst
Outdated
Show resolved
Hide resolved
Per the meeting today, I'm not sure if we want to keep the Competition Manual page with an embed at all. I see 3 options for how to proceed with this PR: |
Yeah, I'm thinking we should just have a central "Competition Resources" page with a listing of all the links that people need. There are a LOT of them. Pages and Links: Competition Specific Resources |
I think that page is a good idea. One concern I have with linking the HTML version of the CM is that the URL has the version number in it, which means that someone would need to update this page every time a new version is released. It’s not a big deal, just something we need to remember that we need to do. |
@texasdiaz where are you getting that html version # in the link? I think this is the correct link and it will update with the versions https://ftc-resources.firstinspires.org/file/ftc/game/cm-html |
I clicked the link on the resources page, and that's the page it sent me to (I just copy-pasted the link in the url bar). If anyone is going to bookmark a link, it's going to be the link in the URL bar and not the link they clicked to take them there that redirected you. Perhaps we need to talk to Jacob to see if we can obfuscate the link to make bookmarking better. |
No description provided.